Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add task solution #4919

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

add task solution #4919

wants to merge 5 commits into from

Conversation

naz4ik
Copy link

@naz4ik naz4ik commented Oct 9, 2024

  • DEMO LINK
  • TEST REPORT LINK
  • [x]Yellow stars are added with container modifier + pseudo-selector (NO extra classes)
    Each BEM block has its own separate file
  • [x]All Typical Mistakes from BEM lesson theory are checked.
  • [x]Code follows all the Code Style Rules ❗️

Доброго дня! я не зрозумів як можна було зробити не активні та активні зірочки без додавання інших классів. я попросив gpt мені допомогти. Могли би ви об'яснити як це можна зробити іншими засобами або об'яснити як він це зробив

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work on your HTML and CSS code! It's structured well and meets all the requirements. Keep it up! 🎉

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

Copy link

@anastasiiavorobiova anastasiiavorobiova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Almost done!

src/index.html Outdated Show resolved Hide resolved
src/style.css Outdated Show resolved Hide resolved
src/style.css Outdated Show resolved Hide resolved
src/style.css Outdated Show resolved Hide resolved
naz4ik and others added 3 commits October 16, 2024 15:13
Co-authored-by: anastasiiavorobiova <[email protected]>
Co-authored-by: anastasiiavorobiova <[email protected]>
Co-authored-by: anastasiiavorobiova <[email protected]>
Copy link

@anastasiiavorobiova anastasiiavorobiova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Make sure to deploy your fixes

src/style.css Outdated Show resolved Hide resolved
.stars--0 .stars__star:nth-child(-n + 0),
.stars--1 .stars__star:nth-child(-n + 1),
.stars--2 .stars__star:nth-child(-n + 2),
... {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, add all selectors here

Co-authored-by: anastasiiavorobiova <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants